[Flink] Reduce excessively long thread sleep #5940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waywtdcc thanks for your contribution, please restore the PR description template and fill it in seriously, the detailed change description and review history are extremely important to an open-source project. |
|
@link3280 @YesOrNo828 do you have suggestions/concerns on changing this value? Or maybe we should make it configurable? |
|
The default fetch interval is the same as CliTableResultView in Flink SQL client, which I think is a reasonable default. I would rather make it configurable if necessary. |
|
+1 make it configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #5891
Reduce excessively long thread sleep